GH-16504: avoid seg fault when creating new lazy class instance fails #16506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
requested review from
Girgias,
NattyNarwhal,
SakiTakamachi,
TimWolla,
adoy,
bukka,
derickr,
devnexen,
dstogov,
kocsismate,
nielsdos and
zeriyoshi
as code owners
|
Misclick, sorry for the spam! |
DanielEScherzer
force-pushed
the
lazy-clone
branch
from
f1ac1ec to
2d5f104
Compare
TimWolla
requested review from
arnaud-lb
and removed request for
Girgias,
NattyNarwhal,
SakiTakamachi,
TimWolla,
adoy,
bukka,
derickr,
devnexen,
dstogov,
kocsismate,
nielsdos and
zeriyoshi
|
Thank you @DanielEScherzer! I think this fixes the same issue as #15856. |
Okay, before I spend time to work on fixing up the failures here, do you plan on merging that one soon? If yes, then I'll just wait for that and re-test the original report, but I agree it should be fixed by that patch too |
|
I think I'm going to merge that one today |
|
I've merged #15856. I confirm that it fixes the same issue |
|
Okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.